Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fieldError to export list #1008

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Add fieldError to export list #1008

merged 3 commits into from
Jan 28, 2020

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Jan 6, 2020

This is an old work account. Please reference @brandonchinn178 for all future communication


Allows people implementing PersistEntity manually to use the fieldError helper

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt
Copy link
Collaborator

Try merging master - there's an upper bound in place to prevent the cabal solver from picking that version.

@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Jan 10, 2020

This is an old work account. Please reference @brandonchinn178 for all future communication


What version bound are you referring to?

@parsonsmatt
Copy link
Collaborator

persistent-mongoDB needs a < 2.6 constraint on mongoDB package. It's in master, and I was able to get it working by just restarting the CI against master.

@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Jan 10, 2020

This is an old work account. Please reference @brandonchinn178 for all future communication


This PR is not about persistent-mongodb?

@parsonsmatt
Copy link
Collaborator

I know. We didn't have an upper bound on persistent-mongoDB so the cabal builders were failing because they were getting the newest version which was incompatible. That's been fixed. So all we need to get this merged is the checkboxes to be done 😄

@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Jan 10, 2020

This is an old work account. Please reference @brandonchinn178 for all future communication


ah ok. I was confused because it looks like CI is passing on this branch.

I wasn't sure which of the checkboxes you needed me to fix. Does this change really require a version bump?

@parsonsmatt
Copy link
Collaborator

The changelog needs to be updated. If you don't want this released, then you can put it in an Unreleased section instead of a minor version bump. If you do want it to be released soon, then we do need to have a new version number to publish it on Hackage.

A @since annotation on the function denoting the version it was released would also be good.

Allows people implementing `PersistEntity` manually to use the `fieldError` helper
@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Jan 10, 2020

This is an old work account. Please reference @brandonchinn178 for all future communication


I wasn't sure what version to put in @since because I'm not setting a next version, so I put @since 2.8.1 for now. Let me know if that needs to be changed

@parsonsmatt parsonsmatt added this to the template-2.8.1 milestone Jan 28, 2020
@parsonsmatt parsonsmatt merged commit 65c947c into yesodweb:master Jan 28, 2020
@parsonsmatt
Copy link
Collaborator

Released in persistent-template-2.8.2, thanks so much! 😄

@brandon-leapyear brandon-leapyear deleted the patch-1 branch November 15, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants