Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Natural instances #1032

Merged
merged 5 commits into from
Mar 31, 2020
Merged

Remove the Natural instances #1032

merged 5 commits into from
Mar 31, 2020

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Feb 11, 2020 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Fixes #1031

@parsonsmatt parsonsmatt added this to the 2.11 milestone Feb 11, 2020
@erikd
Copy link
Contributor

erikd commented Feb 11, 2020

I should stop using it then :).

MaxGabriel
MaxGabriel reviewed Feb 15, 2020
View reviewed changes
persistent/Database/Persist/Class/PersistField.hs
':$$: 'Text "why the instance was removed."
':$$: 'Text ""
':$$: 'Text "This error instance will be removed in a future release."
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty sick

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the good kind of sick right?

@parsonsmatt parsonsmatt merged commit 9997a28 into master Mar 31, 2020
@parsonsmatt parsonsmatt deleted the remove-natural branch March 31, 2020 03:04
@parsonsmatt parsonsmatt mentioned this pull request Sep 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@MaxGabriel MaxGabriel MaxGabriel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Natural values don't fit into an sql database
3 participants
@parsonsmatt @erikd @MaxGabriel