Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix foreign key constraints on custom table names #1041

Merged
merged 10 commits into from
Feb 15, 2020
Merged

Fix foreign key constraints on custom table names #1041

merged 10 commits into from
Feb 15, 2020

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Feb 14, 2020 •
edited
Loading

This PR adds tests for some old issues.

This PR also fixes #373 finally by using the specified tablename in fixForeignKey

@parsonsmatt
Copy link
Collaborator Author

wild, i'm getting a test failure on CI but not locally...

test: SqlError {sqlState = "42P01", sqlExecStatus = FatalError, sqlErrorMsg = "relation \"tree\" does not exist", sqlErrorDetail = "", sqlErrorHint = ""}

@parsonsmatt parsonsmatt changed the title Add test for mutual recursion and trees Fix foreign key constraints on custom table names Feb 14, 2020
@parsonsmatt parsonsmatt merged commit d477eb6 into master Feb 15, 2020
@parsonsmatt parsonsmatt deleted the matt/tests branch March 31, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicit foreign keys can't reference tables with custom sql name
1 participant
@parsonsmatt