Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't derive Show for Unique #1127

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Don't derive Show for Unique #1127

merged 2 commits into from
Sep 18, 2020

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Sep 18, 2020 •
edited

Fixes #988

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt parsonsmatt added this to the 2.11 milestone Sep 18, 2020
@parsonsmatt parsonsmatt merged commit 0c3d32d into master Sep 18, 2020
@cdparks cdparks mentioned this pull request Nov 4, 2020
Closed
3 tasks
@parsonsmatt parsonsmatt deleted the 988-no-show-unique branch April 20, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Requirement of a Show instance for Unique is not good
1 participant
@parsonsmatt