Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exists query #1131

Merged
merged 10 commits into from Oct 29, 2020
Merged

Exists query #1131

merged 10 commits into from Oct 29, 2020

Conversation

limick
Copy link
Contributor

@limick limick commented Oct 2, 2020

Note: Since I no longer have access to the previous repository, this replaces PR #1070 . I've applied the suggestions from that PR and I'm updating the changelog files to reflect the new PR number.

This addresses #1069 by adding an exists function to the PersistQueryRead type class, which already provides the count function. The count function will be used for a fallback implementation for backends that don't provide a separate existence check.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@limick limick mentioned this pull request Oct 2, 2020
5 tasks
@limick limick marked this pull request as ready for review October 2, 2020 19:39
@parsonsmatt parsonsmatt added this to the 2.11 milestone Oct 29, 2020
@parsonsmatt
Copy link
Collaborator

Wonderful, thanks!

@parsonsmatt parsonsmatt merged commit c9be781 into yesodweb:master Oct 29, 2020
@parsonsmatt parsonsmatt mentioned this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants