Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate hasCompositeKey and provide replacements #1142

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Deprecate hasCompositeKey and provide replacements #1142

merged 3 commits into from
Oct 30, 2020

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Oct 29, 2020 •
edited

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Fixes #685

@parsonsmatt parsonsmatt added this to the 2.11 milestone Oct 29, 2020
@parsonsmatt parsonsmatt merged commit 0b8f9f3 into master Oct 30, 2020
@parsonsmatt parsonsmatt deleted the matt/has-composite-key branch April 1, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

hasCompositeKey is technically wrong (alternatively: natural key support?)
1 participant
@parsonsmatt