Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared Primary Keys #1148

Merged
merged 5 commits into from
Oct 31, 2020
Merged

Shared Primary Keys #1148

merged 5 commits into from
Oct 31, 2020

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Oct 31, 2020 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Fixes #1147

parsonsmatt
parsonsmatt commented Oct 31, 2020
View reviewed changes
persistent-template/Database/Persist/TH.hs
@@ -1677,7 +1677,7 @@ liftAndFixKeys entityMap EntityDef{..} =
[|EntityDef
entityHaskell
entityDB
entityId
$(liftAndFixKey entityMap entityId)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual fix.

@parsonsmatt parsonsmatt merged commit ba51ec0 into master Oct 31, 2020
@parsonsmatt parsonsmatt deleted the shared-primary-keys branch October 31, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL types are wrong for shared primary keys
1 participant
@parsonsmatt