Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add space in cascade SQL and fix docs. #1153

Merged
merged 6 commits into from
Nov 5, 2020
Merged

Add space in cascade SQL and fix docs. #1153

merged 6 commits into from
Nov 5, 2020

Conversation

friedbrice
Copy link
Contributor

@friedbrice friedbrice commented Nov 5, 2020 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

parsonsmatt
parsonsmatt approved these changes Nov 5, 2020
View reviewed changes
persistent/ChangeLog.md Outdated Show resolved Hide resolved
@friedbrice friedbrice changed the title Friedbrice/add space in cascade sql Add space in cascade SQL and fix docs. Nov 5, 2020
@friedbrice @parsonsmatt
Update persistent/ChangeLog.md
19add53 
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
@friedbrice friedbrice closed this Nov 5, 2020
@friedbrice friedbrice reopened this Nov 5, 2020
@friedbrice
Copy link
Contributor Author

Good to go. Thanks @parsonsmatt!

@parsonsmatt parsonsmatt merged commit 32a9421 into yesodweb:master Nov 5, 2020
parsonsmatt added a commit that referenced this pull request Nov 5, 2020
@friedbrice @parsonsmatt
Add space in cascade SQL and fix docs. (#1153)
ce36ba8 
* add space in cascade sql

* fix doc string

* bump versions

* add changelog entry

* add link in changelog

* Update persistent/ChangeLog.md

Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>

Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
@friedbrice friedbrice deleted the friedbrice/add-space-in-cascade-sql branch November 5, 2020 19:05
@friedbrice
Copy link
Contributor Author

friedbrice commented Nov 5, 2020 •
edited
Loading

Hi, @parsonsmatt. I noticed persistent-2.11.0.1 made it to Hackage successfully, but could you please also upload persistent-postgresql-2.11.0.1 to Hackage as well? Thanks!

(If Hackage upload is automated and the bots just haven't gotten around to it yet, I'm sorry!)

@parsonsmatt
Copy link
Collaborator

There weren't any changes made to persistent-postgresql in this PR, so I reverted the version bump.

@friedbrice
Copy link
Contributor Author

friedbrice commented Nov 5, 2020 •
edited
Loading

Oh! I'm so sorry. I was just confused then. I thought the ON DELETE -> ON DELETE was in a file in the postgresql package. Thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@friedbrice @parsonsmatt