Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QoL API for using BaseBackend/BackendCompatible #1178

Merged
merged 6 commits into from
Jan 6, 2021

Conversation

ivanbakel
Copy link
Contributor

@ivanbakel ivanbakel commented Dec 21, 2020

withBaseBackend and withCompatibleBackend are simple wrappers for withReaderT that use the appropriate read-transforming function from their respective instances.

Also dogfoods these functions into the codebase.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

'withBaseBackend' and 'withCompatibleBackend' are simple wrappers for
'withReaderT' that use the appropriate read-transforming function from
their respective instances.

Also dogfoods these functions into the codebase.
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks!

persistent/Database/Persist/Class/PersistStore.hs Outdated Show resolved Hide resolved
persistent/Database/Persist/Class/PersistStore.hs Outdated Show resolved Hide resolved
@parsonsmatt parsonsmatt merged commit 332f0a6 into yesodweb:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants