Avoid unnecessary REFERENCES clause during table creation
#1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2021 21:24
…out a FOREIGN_KEY specification which late MariaDB versions considers a malformed statement
|
Closing this pull request so I can resubmit with a clean branch and avoid a messy history |
parsonsmatt
changed the base branch from
master
to
matt/persistent-mysql-migration-fix
|
going to fix this and get it released tonight, thanks! |
parsonsmatt
added a commit
that referenced
this pull request
Jan 27, 2022
* avoid specifying a REFERENCES clause during MySQL table creation without a FOREIGN_KEY specification which late MariaDB versions considers a malformed statement * relax mysql dependency * changelog, cabal * stylish-haskell Co-authored-by: Erick Gonzalez <erick.gonzalez@secucloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into issue #1158 , which basically renders DB migrations unusable with MariaDB (at least since version 10.5). The solution proposed by Markus Linik (@mklinik) works as expected. In a nutshell, the
REFERENCESpart of a CREATE TABLE statement is suppressed for foreign keys and this specification is delayed until the subsequent ALTER TABLE which sets it up correctly (as it always has).