Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose orderClause from PersistQuery.hs #1317

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Expose orderClause from PersistQuery.hs #1317

merged 2 commits into from
Oct 7, 2021

Conversation

ivb-supercede
Copy link
Contributor

@ivb-supercede ivb-supercede commented Sep 9, 2021

This is part of the followup to #1298.

This exposes orderClause in a similar manner to filterClause, to help third-party libraries which want to format their own SQL queries using Persistent's internal helpers.

It rewrites orderClause a bit to bring it in line with the other exposed functions, but there should be no functional changes as a result.

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This is part of the followup to #1298.

This exposes `orderClause` in a similar manner to `filterClause`, to
help third-party libraries which want to format their own SQL queries
using Persistent's internal helpers.

It rewrites `orderClause` a bit to bring it in line with the other
exposed functions, but there should be no functional changes as a
result.
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@parsonsmatt parsonsmatt merged commit 9bbb406 into yesodweb:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants