Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insert safety issues #1387

Merged
merged 12 commits into from
Apr 12, 2022
Merged

Fix insert safety issues #1387

merged 12 commits into from
Apr 12, 2022

Conversation

parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Apr 12, 2022

Error message for functions:

image

Error message for Entity:

image

Can't use insert with a non-default now 🎉

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Fixes #1299

@parsonsmatt parsonsmatt added this to the 2.14 milestone Apr 12, 2022
@parsonsmatt parsonsmatt merged commit b179809 into master Apr 12, 2022
@parsonsmatt parsonsmatt deleted the matt/fix-insert-safety-issues branch April 12, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better UX on insert
1 participant