Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing quasi module test coverage, improve error assertions #1391

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Increasing quasi module test coverage, improve error assertions #1391

merged 2 commits into from
Apr 13, 2022

Conversation

danbroooks
Copy link
Contributor

@danbroooks danbroooks commented Apr 13, 2022 •
edited by parsonsmatt
Loading

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt
Copy link
Collaborator

awesome! want to put a changelog entry? happy to release as a patch or do an (unreleased)

danbroooks
danbroooks commented Apr 13, 2022
View reviewed changes
persistent/ChangeLog.md
* [#1391](https://github.com/yesodweb/persistent/pull/1391)
* Increasing quasi module test coverage, improve error assertions

## 2.14.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this because 2.14.0.0 is released now, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! great catch 😄

@parsonsmatt parsonsmatt merged commit fd1f774 into yesodweb:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parsonsmatt parsonsmatt parsonsmatt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danbroooks @parsonsmatt