Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for discoverEntities being jacked #1428

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Sep 26, 2022

I have literally no idea why haddock was unhappy about them before, but I just changed it to a block comment and it worked.

Haddock wasn't seeing them at all, to be clear: it thought there were no docs. No idea what that was about.

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Jade Lovelace added 2 commits September 26, 2022 15:41
I have literally no idea why haddock was unhappy about them before, but
I just changed it to a block comment and it worked.
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao what

@parsonsmatt parsonsmatt merged commit 5a38dae into yesodweb:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants