Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error message wording #1438

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Clarify error message wording #1438

merged 3 commits into from
Dec 2, 2022

Conversation

friedbrice
Copy link
Contributor

Just suggesting a wording change on the warning message when trying to add a uniqueness constraint to a nullable column.

Some people were confused about whether this warning came from our in-house code or from Persistent, so I clarified that. Also, some people were confused about whose equality semantics treated nulls as not equal, so I clarified that it's a SQL thing.


Before submitting your PR, check that you've:

- [ ] Documented new APIs with [Haddock markup](https://www.haskell.org/haddock/doc/html/index.html)
- [ ] Added [`@since` declarations](http://haskell-haddock.readthedocs.io/en/latest/markup.html#since) to the Haddock
- [ ] Ran `stylish-haskell` on any changed files.
- [ ] Adhered to the code style (see the `.editorconfig` file for details)

After submitting your PR:

- [ ] Update the Changelog.md file with a link to your PR
- [ ] Bumped the version number if there isn't an `(unreleased)` on the Changelog
- [ ] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

<!---Thanks so much for contributing! :)

_If these checkboxes don't apply to your PR, you can delete them_-->

@parsonsmatt parsonsmatt merged commit f7382d9 into yesodweb:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants