Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make repsert a special case of repsertMany #1452

Conversation

njohnwalker
Copy link
Contributor

@njohnwalker njohnwalker commented Dec 16, 2022

repsertMany admits backends to provide a custom implementation via connRepsertManySql. in the case of the postrgres backend, repsertMany becomes an atomic operation. It would be nice to take advantage of this for repsert as well. (it's fairly well known as a gotcha in our codebase but this would be a nice QoL improvement for us)

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@njohnwalker njohnwalker marked this pull request as draft December 16, 2022 19:56
@njohnwalker njohnwalker marked this pull request as ready for review December 16, 2022 23:37
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@parsonsmatt parsonsmatt merged commit 0c57453 into yesodweb:master Dec 17, 2022
@parsonsmatt
Copy link
Collaborator

Uploaded as persistent-2.14.4.3

@njohnwalker
Copy link
Contributor Author

no, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants