Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle qualified table name #1477

Merged
merged 9 commits into from Oct 3, 2023

Conversation

wavewave
Copy link
Contributor

@wavewave wavewave commented Mar 2, 2023

When a table name is specified with qualifier, the guessed name for SqlType had better be qualified by default in order to avoid potential name collisions with the unqualified name.

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@wavewave wavewave marked this pull request as draft March 30, 2023 00:53
@wavewave wavewave marked this pull request as ready for review April 3, 2023 16:15
@parsonsmatt parsonsmatt merged commit bd32280 into yesodweb:master Oct 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants