Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpsAvoidHsKeyword in MkPersistSettings #1480

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

ccycle
Copy link
Contributor

@ccycle ccycle commented Mar 14, 2023

This PR adds an option in MkPersistSettings to customise function for field accessors applied only when the field name matches any of Haskell keywords. (inspired by @parsonsmatt 's comment in #1476 (review))

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt
Copy link
Collaborator

This is great, thanks! Mind doing a minor version bump?

@ccycle
Copy link
Contributor Author

ccycle commented Jun 2, 2023

@parsonsmatt Thank you, I added a change to bump minor version.

@parsonsmatt parsonsmatt merged commit e2b1a11 into yesodweb:master Oct 3, 2023
7 checks passed
@ccycle ccycle deleted the custom-keyword-modifier branch October 4, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants