postgres(normalize types to eliminate noop migrations) #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. If you want to add a test and finish the PR checklist I'd be happy to do a patch release. |
HugoPeters1024
force-pushed
the
master
branch
from
5f74dd3
to
216eaa2
Compare
parsonsmatt
requested changes
Sep 21, 2023
Comment on lines
+3
to
+6
| ## 2.14.6.1 (unreleased) | ||
|
|
||
| * [#1518](https://github.com/yesodweb/persistent/pull/1518) | ||
| * Normalize postgres type aliases to prevent noop migrations |
There was a problem hiding this comment.
The change is actually in persistent-postgresql, not persistent, so you'll want to make the version bump and changelog modification there 😄
There was a problem hiding this comment.
thanks for fixing it :)
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1517. I've kept the list non exhaustive because I simply was not sure how to handle every case. Notably when the alias did not have a placeholder variable but the base name did (e.g. timestamptz). I also looked around in the
Postgresql.Simplemodules to see if something like this already existed but it did not look like it.At the risk of sounding selfish, this fixes my immediate problem does not make the code worse.
Before submitting your PR, check that you've:
stylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog