Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Postgres migrations to enable extensions #748

Merged
merged 4 commits into from
Jan 18, 2018

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Nov 27, 2017

This is kind of ugly, I'm happy to take feedback.

@MaxGabriel
Copy link
Member

@enolan Why not just run CREATE EXTENSION IF NOT EXISTS instead of checking, then running? I think that would simplify the code greatly.

@enolan
Copy link
Contributor Author

enolan commented Dec 4, 2017

That's what I had originally, but it means that the migration always prints when you start your program, which is a little annoying and a little confusing.

@MaxGabriel
Copy link
Member

@enolan I think this is a good PR then. Can you bump the version number of the cabal file and add a changelog entry?

@enolan
Copy link
Contributor Author

enolan commented Dec 23, 2017

I bumped the version number and added a changelog entry. Something weird is happening with Travis, but I'm pretty sure it has nothing to do with my code.

@MaxGabriel MaxGabriel merged commit bad9ea9 into yesodweb:master Jan 18, 2018
@MaxGabriel
Copy link
Member

Merged! Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants