Improve error message when a SQL insert fails with a custom primary key #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My coworker was using a custom primary key like so:
```
User sql=users
Id sqltype=uuid default=uuid_generate_v4
email Email sqltype=text
UniqueEmail email
createdAt UTCTime
modifiedAt UTCTime
deriving Show Eq Typeable
```
But didn't specify the type of the Id to be UUID. This caused Persistent to expect an Int64, leading to a very confusing error message on insert:
```
*** Exception: runFakeHandler issue: InternalError "Invalid result from a SQL insert, got: [PersistDbSpecific \"70c2418d-fb00-43f7-818d-eaf962612030\"]
```
By providing the actual underlying error, it gets much clearer:
```
*** Exception: runFakeHandler issue: InternalError "Invalid result from a SQL insert, got: [PersistDbSpecific \"70c2418d-fb00-43f7-818d-eaf962612030\"]. Error was: \"int64 Expected Integer, received: PersistDbSpecific \\\"70c2418d-fb00-43f7-818d-eaf962612030\\\"\"
```
MaxGabriel
force-pushed
the
improveSqlInsertErrorMessage
branch
from
189e843
to
9a16736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My coworker was using a custom primary key like so:
But didn't specify the type of the Id to be UUID. This caused Persistent to expect an Int64, leading to a very confusing error message on insert:
By providing the actual underlying error, it gets much clearer:
Not sure if a new version is necessary for this, but I'm holding off since the
masterversion of Persistent is deprecated anyway.