Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showable Unique #826

Merged
merged 4 commits into from
Sep 17, 2018
Merged

Showable Unique #826

merged 4 commits into from
Sep 17, 2018

Conversation

pythonissam
Copy link

@pythonissam pythonissam commented Aug 17, 2018

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@pythonissam
Copy link
Author

issue ref: #802

@bitemyapp bitemyapp changed the title Showble Unique Showable Unique Aug 17, 2018
@pythonissam
Copy link
Author

pythonissam commented Sep 17, 2018

@snoyberg Well, can you review my PR?

@snoyberg
Copy link
Member

FYI, I don't typically maintain persistent on a regular basis, so I'm not the best person to review PRs.

I was going to ask why a major version bump, but upon reflection I agree that it has the potential to cause compilation breakage even in the absence of orphan instances.

@snoyberg snoyberg merged commit 2d86a52 into yesodweb:master Sep 17, 2018
@snoyberg snoyberg mentioned this pull request Sep 17, 2018
@pythonissam pythonissam deleted the unique-show-instance branch September 20, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants