This PR adds read/write tests to check functionality on the read/write backens. #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
commented
Apr 12, 2019
| @@ -170,6 +171,7 @@ main = do | |||
| >> runMigrationSilent MigrationOnlyTest.migrateAll2 | |||
| ) | |||
| PersistentTest.specsWith db | |||
| ReadWriteTest.specsWith db | |||
There was a problem hiding this comment.
... it would probably be nice for PersistentTest to export two functions like allBackendsMustPass and sqlBackendsMustPass that these other ones can reuse rather than copying the definition everywhere
| , SqlReadBackend (unSqlReadBackend) | ||
| , SqlWriteBackend (unSqlWriteBackend) | ||
| , SqlReadBackend (..) | ||
| , SqlWriteBackend (..) |
There was a problem hiding this comment.
I have no idea why the constructors were hidden. Presumably you were only supposed to use the IsSqlBackend instance, but that lets you construct them, so 🤷♂️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR: