-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Stackage Nightly #977
Conversation
@@ -26,7 +27,7 @@ toEntityString = unDBName . entityDB . entityDef . Just | |||
toEntityName :: EntityDef -> B.ByteString | |||
toEntityName = U.fromString . unpack . unDBName . entityDB | |||
|
|||
mkEntity :: (Monad m, PersistEntity val) => Key val -> [(B.ByteString, B.ByteString)] -> m (Entity val) | |||
mkEntity :: (MonadFail m, PersistEntity val) => Key val -> [(B.ByteString, B.ByteString)] -> m (Entity val) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically a breaking change, but it's an .Internal
module, so yolo
@@ -1,5 +1,5 @@ | |||
name: persistent-redis | |||
version: 2.5.2.2 | |||
version: 2.5.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should possibly be a major bump, but only type-changing thing is in the internal module
@@ -224,7 +224,7 @@ main = do | |||
return () | |||
it "issue #527" $ asIO $ runSqliteInfo (mkSqliteConnectionInfo ":memory:") $ do | |||
runMigration migrateAll | |||
insertMany_ $ replicate 1000 (Test $ read "2014-11-30 05:15:25.123") | |||
insertMany_ $ replicate 1000 (Test $ read "2014-11-30 05:15:25.123Z") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the Read
instance for UTCTime changed :|
Before submitting your PR, check that you've:
@since
declarations to the HaddockAfter submitting your PR:
Well,
persistent-mongoDB
'smongoDB
dependency is causing issues, so we're not building it - otherwise it'd fail the whole build.