Changed persistent-mysql to use 'utf8mb4' instead of 'utf8' in migrations #980
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SET in VARCHAR and TEXT migrations Co-authored-by: charukiewicz <c.charukiewicz@gmail.com> Co-authored-by: belevy <benjaminlevy007@gmail.com>
|
I'm happy with this change. Is it a drop-in 100% improvement with no possible breaking change behavior? |
|
As far as I know, yes. |
|
awesome! I'll try to get this released this weekend. |
|
Released as |
This was referenced Feb 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in title, this changes migration behavior for the
VARCHARandTEXTcolumn types to use theuft8mb4character set as opposed touft8. This is becauseutf8is an alias forutf8mb3which does not properly handle all UTF-8 strings. Here's another StackOverflow answer that discusses this.Not sure if this is worth a version number bump, as
utf8mb4is fully backwards compatible. Let me know if I should bump the version.Before submitting your PR, check that you've:
After submitting your PR: