Derive Generic instances for non-generic newtype keys #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessekempf
force-pushed
the
generic-instances-for-keys
branch
from
6e05d72
to
8dad9e5
Compare
jessekempf
force-pushed
the
generic-instances-for-keys
branch
from
8dad9e5
to
d054f34
Compare
parsonsmatt
approved these changes
Nov 26, 2019
| -- | ||
| -- Default: [] | ||
| -- | ||
| -- @since 2.7.4 |
| @@ -902,6 +912,8 @@ mkKeyTypeDec mps t = do | |||
| useNewtype = pkNewtype mps t | |||
| customKeyType = not (defaultIdType t) || not useNewtype || isJust (entityPrimary t) | |||
|
|
|||
| supplement :: [Name] -> [Name] | |||
| supplement names = names <> (filter (`notElem` names) $ mpsDeriveInstances mps) | |||
There was a problem hiding this comment.
i feel like these somewhat awkward elem dances could be made easier by a gentle use of Set
|
|
||
| import Database.Persist | ||
| import Database.Persist.TH | ||
| import TemplateTestImports | ||
|
|
||
|
|
||
| share [mkPersist sqlSettings { mpsGeneric = False }, mkDeleteCascade sqlSettings { mpsGeneric = False }] [persistUpperCase| | ||
| share [mkPersist sqlSettings { mpsGeneric = False, mpsDeriveInstances = [''Generic] }, mkDeleteCascade sqlSettings { mpsGeneric = False }] [persistUpperCase| |
| else do | ||
| let allInstances = [''Show, ''Read, ''Eq, ''Ord, ''PathPiece, ''ToHttpApiData, ''FromHttpApiData, ''PersistField, ''PersistFieldSql, ''ToJSON, ''FromJSON] | ||
| let allInstances = supplement [''Show, ''Read, ''Eq, ''Ord, ''PathPiece, ''ToHttpApiData, ''FromHttpApiData, ''PersistField, ''PersistFieldSql, ''ToJSON, ''FromJSON] |
There was a problem hiding this comment.
Point for future upgrade: remove the unnecessary instances here like PathPiece, ToHttpApiData, etc that don't make sense for non-web-apps.
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
After submitting your PR: