Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New contentHash parser breaks hash hrefs #200

Closed
bermanjosh opened this issue Dec 27, 2016 · 6 comments
Closed

New contentHash parser breaks hash hrefs #200

bermanjosh opened this issue Dec 27, 2016 · 6 comments

Comments

@bermanjosh
Copy link

I think #198 breaks the following:
<a #logoutbutton href=#>

It returns the following error:

unexpected "h"
expecting ">"

@snoyberg
Copy link
Member

Pinging @terickson001, I'm probably going to have to revert the change.

@bermanjosh interested in sending a PR for an additional test case to prevent this regression in the future?

@terickson001
Copy link
Contributor

Sorry about that, overlooked Attributes a bit when I was testing. Should be fixed in this PR.

terickson001 added a commit to terickson001/shakespeare that referenced this issue Dec 27, 2016
@joeyh
Copy link

joeyh commented Dec 27, 2016

I'm getting what seems like the same kind of reversion with 2.0.12

<a .btn .btn-default data-toggle="collapse" data-target="##{ident}">#{toggle}

unexpected "d"
expecting ">"

I think the 'd' is from data-target.

@terickson001
Copy link
Contributor

@joeyh That is fixed in PR #201, I just tested it to be sure.

garetxe pushed a commit to garetxe/stackage that referenced this issue Dec 27, 2016
@bermanjosh
Copy link
Author

@terickson001 Thanks!
@snoyberg Ok if I close the issue?

@snoyberg
Copy link
Member

snoyberg commented Dec 28, 2016 via email

snoyberg added a commit that referenced this issue Dec 28, 2016
snoyberg added a commit to commercialhaskell/stackage that referenced this issue Dec 28, 2016
DanBurton added a commit to commercialhaskell/stackage that referenced this issue Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants