New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New contentHash parser breaks hash hrefs #200
Comments
Pinging @terickson001, I'm probably going to have to revert the change. @bermanjosh interested in sending a PR for an additional test case to prevent this regression in the future? |
Sorry about that, overlooked Attributes a bit when I was testing. Should be fixed in this PR. |
I'm getting what seems like the same kind of reversion with 2.0.12 <a .btn .btn-default data-toggle="collapse" data-target="##{ident}">#{toggle} unexpected "d" I think the 'd' is from data-target. |
@terickson001 Thanks! |
Yes, sounds good, I'll merge and release shortly.
…On Wed, Dec 28, 2016, 9:56 AM Josh Berman ***@***.***> wrote:
@terickson001 <https://github.com/terickson001> Thanks!
@snoyberg <https://github.com/snoyberg> Ok if I close the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#200 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADBB9JrHWMXqWt3bLG5kkjRJH4NaArhks5rMhYggaJpZM4LWIPL>
.
|
This reverts commit d1fb15f.
Revert "Constrain shakespeare per yesodweb/shakespeare#200"
I think #198 breaks the following:
<a #logoutbutton href=#>
It returns the following error:
The text was updated successfully, but these errors were encountered: