Expose Text.Internal.Css #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we at least add a Haddock comment to the top of these modules that they are only being exposed to work around a GHC bug, and that the modules should not be relied upon? |
This change allows to fix yesod on 8.0.1 compiler by adding: ```haskell import Text.Css (Block(..)) ``` to the failing modules
|
I hid them from haddock and moved them to |
snoyberg
approved these changes
Apr 19, 2017
snoyberg
added a commit
that referenced
this pull request
Apr 19, 2017
|
Thanks! Releasing to Hackage now.
…On Wed, Apr 19, 2017 at 3:20 PM, Marcin Tolysz ***@***.***> wrote:
I hid them from haddock and moved them to Text.Internal.Css*
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#205 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADBBw7vsCvtzvtgoZy4PV8HEuScm3JPks5rxfwogaJpZM4NAUbg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to fix
yesodon 8.0.1 compiler by adding:to the failing modules
i.e. ones which die with:
fixes: #203