deleted: drop GHC 7 test #225
Conversation
Text/Hamlet.hs
Outdated
| @@ -154,7 +147,7 @@ mkConName :: DataConstr -> Name | |||
| mkConName = mkName . conToStr | |||
|
|
|||
| conToStr :: DataConstr -> String | |||
| conToStr (DCUnqualified (Ident x)) = x | |||
| conToStr (DCUnqualified (Ident x)) = x | |||
There was a problem hiding this comment.
I'm not in favor of these alignment changes, they create large diffs in PRs unnecessarily.
| @@ -82,9 +82,6 @@ library | |||
|
|
|||
| extensions: TemplateHaskell | |||
|
|
|||
| if impl(ghc >= 7.4) | |||
There was a problem hiding this comment.
There's no change in the cabal file to indicate that GHC 7 is no longer supported, e.g. base >= 4.9.
ncaq
force-pushed
the
delete-ghc-7
branch
6 times, most recently
from
6ec7fc0
to
5cf32e0
Compare
|
@snoyberg I do alignment import list and pragma. |
That's exactly why the arbitrary restyling and reordering should not be included here, I can't reliably tell what has and has not changed. |
Yesod drop support GHC 7. [yesod/.travis.yml at cdba6c1678d8002eac94ba175e00183a7e87c09d · yesodweb/yesod](https://github.com/yesodweb/yesod/blob/cdba6c1678d8002eac94ba175e00183a7e87c09d/.travis.yml) GHC 7 is slow, and GHC 7 support add CPP switch. To drop GHC 7 get correct travis test and simple code. I delete unneed CPP pragma. I rename `pattern` to `newPattern` because it cause hlint error.
|
@snoyberg |
Yesod drop support GHC 7.
yesod/.travis.yml at cdba6c1678d8002eac94ba175e00183a7e87c09d ·
yesodweb/yesod
GHC 7 is slow, and GHC 7 support add CPP switch.
To drop GHC 7 get correct travis test and simple code.
I delete unneed CPP pragma.
And I run stylish-haskell all source code.
Because I want to detect unneed import.