Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stextFile to Text.Shakespeare.Text #240

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Add stextFile to Text.Shakespeare.Text #240

merged 1 commit into from
Oct 10, 2019

Conversation

lexi-lambda
Copy link
Contributor

This adds stextFile to Text.Shakespeare.Text, which is to textFile as shamletFile is to hamletFile.

@snoyberg
Copy link
Member

A few comments, could you please

  1. Add a minor version bump
  2. Add a ChangeLog entry
  3. Add some Haddocks explaining what this function does, including a @since annotation

@lexi-lambda
Copy link
Contributor Author

@snoyberg Thanks, I’ve now done so.

snoyberg
snoyberg approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@snoyberg snoyberg merged commit 7c2da17 into yesodweb:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lexi-lambda @snoyberg