-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for aeson-2 #260
Fix for aeson-2 #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
.github/workflows/tests.yml
Outdated
includes: | ||
- os: ubuntu-latest | ||
resolver: nightly | ||
extra_args: --stack-yaml=stack-ghc-9.2.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, on closer inspection, it looks like the builds are reporting using this for all builds now. I'd recommend unifying this with resolver
as something like:
resolver:
- --resolver nightly
- --resolver lts-18
- ...
- --stack-yaml=stack-ghc-9.2.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, can you try it again? I used includes
instead of include
🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird... I'm not sure why it's not working. But i'll change it anyway
Thanks! |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨
Resolves #258
Not sure how to / if I should add aeson-2 to the CI matrix, but it builds locally