Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for -XTypeApplications #279

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mixphix
Copy link

@mixphix mixphix commented May 6, 2024

Augments the Shakespeare base parser to support parsing type applications, e.g. #{show @Integer 4}, to improve working with polymorphism within quasi-quotes. Will parse type constructors, symbol types, type-level naturals, and single-depth compositions thereof, but will not parse things like @(Const (Maybe a) b) with nested parentheses.

@mixphix
Copy link
Author

mixphix commented May 7, 2024

The earliest GHC version this could support is 8.2.1 (2017), according to the metadata for the commit introducing AppTypeE to template-haskell. If older compiler support is required, we can add the preprocessor directives.

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Can you add a minor version bump and a ChangeLog comment about the addition?

@snoyberg
Copy link
Member

If older compiler support is required, we can add the preprocessor directives.

No, it's fine to support only GHC 8.2 and up.

@mixphix
Copy link
Author

mixphix commented May 13, 2024

I've bumped the version number and edited the changelog. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants