feat(wai-handler-launch): Add function to launch arbitrary URLs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the function runHostPortFullUrl to allow launching arbitrary URLs instead of the hardcoded base http://127.0.0.1. It allows using ::1 as the host IP address, while launching http://[::1]/, where the additional brackets are required to access IPv6 IPs from the browser. As the generation of the URL is moved into runHostPortUrl, both the C launch function and the Haskell launch function can be reduced to (C)String -> IO () without breaking backwards compability.
CRTified
added a commit
to CRTified/wai-handlers
that referenced
this pull request
Jan 15, 2020
|
Looks like the CI fails are all caused by broken dependencies (QtWebKit) or deprecated functions. I am assuming that they are unrelated to my changes. |
snoyberg
requested changes
Jan 15, 2020
CRTified
force-pushed
the
fix/issue-1-ipv6
branch
from
d11a704
to
f9c1245
Compare
|
Is it preferred to squash the commits together? |
|
Unfortunately, this fails to build on Windows, just revealed by hledger's CI: |
|
Ah, I think it should be |
snoyberg
added a commit
that referenced
this pull request
Jan 18, 2020
|
Good catch, thanks! I'm uploading the fix shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the function
runHostPortFullUrlto allow launchingarbitrary URLs instead of the hardcoded base
http://127.0.0.1.It allows using
::1as the host IP address, while launchinghttp://[::1]/,where the additional brackets are required to access IPv6 IPs from the browser.
As the generation of the default URL is moved into
runHostPortUrl, both the C launchfunction and the Haskell launch function can be reduced to (C)String -> IO ()
without breaking backwards compability.
This closes #1
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
Todo