wai-app-static does not redirect on folders

[tolysz]

Hi,

I run into this serving static folders, the issue is when

somefolder/
     index.html  ( <img src="picture.jpg" /> )
     picture.jpg

Now whenever I request https://example.com/somefolder I have broken picture box
and whenever https://example.com/somefolder/ not.

The former tries to access picture.jpg from /picture.jpg the later /somefolder/picture.jpg

The solution could be to Redirect if the Pieces elements point to a folder but does not have / if it has some pathpieces in them (not the clean root)

[snoyberg]

Is this occurring using yesod-static inside a Yesod app, or directly using wai-app-static? Can you give a minimal reproducing example if the latter?

There are some latent issues with yesod-static when using directory listings, I don't remember the details offhand, but I think it's related.

[tolysz]

any application which uses wai static e.g.

 mkdir subfolder
 cp pix.png subfolder
 start warp
 navigate to http://127.0.0.1:3000/subfolder
 click on pix.png (404)
 navigate to http://127.0.0.1:3000/subfolder/
 click on pix.png ( works )

The most probable candidates are:
wai/wai-app-static/Network/Wai/Application/Static.hs # setLast and serveFolder to redirect to path + / if it is not root nor it ends on /

[snoyberg]

OK, I think I know where the problem is coming from, though I'll probably only have time to look at this in the middle of next week.

[snoyberg]

I believe this is now fixed, can you check the newest master?

[tolysz]

looks good