Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad range handling #346

Closed
snoyberg opened this issue Mar 8, 2015 · 4 comments
Closed

Bad range handling #346

snoyberg opened this issue Mar 8, 2015 · 4 comments

Comments

@snoyberg
Copy link
Member

snoyberg commented Mar 8, 2015

Spinning off from snoyberg/keter#75. There are in fact two different bugs:

  1. A 0-length file is being served with a 416 status code, which is invalid. Source of that bug is d9cb4b7#diff-d36a96a05c6b1ee5fbccb0bd0f6ed50cR228, and is easily resolved (f1f658b).
  2. When a 416 response is served, both chunked serving and a content-length are used, which is completely invalid and rightfully breaks clients.

Pinging @jgreve-github @creichert
@snoyberg
Copy link
Member Author

snoyberg commented Mar 8, 2015

And d9cb4b7#diff-d36a96a05c6b1ee5fbccb0bd0f6ed50cR232 is the cause of the second bug. It sets True to require that the response be chunked, but also includes the content-length in hs1. Fortunately this is also an easy fix.

snoyberg added a commit that referenced this issue Mar 8, 2015
@snoyberg
Don't serve content-length for 416 responses #346
f006383
@snoyberg
Copy link
Member Author

snoyberg commented Mar 8, 2015

Changes released in warp 3.0.9.3, closing.

@snoyberg snoyberg closed this as completed Mar 8, 2015
@creichert
Copy link
Member

+1, Good find.

@snoyberg
Copy link
Member Author

snoyberg commented Mar 8, 2015

Heh, thanks. In reality, -1, bad job merging :(

@creichert creichert mentioned this issue Jul 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoyberg @creichert