Auto-flush in 'Detailed' log format #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
added a commit
that referenced
this pull request
Jan 26, 2014
Auto-flush in 'Detailed' log format
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with wai-extra-2.0.3.1, the logging in "Detailed" format (eg yesod devel) is not flushed promptly. Not even as promptly as Apache or CustomOutputFormat! This is about the simplest possible fix to improve it.
The criticism of this fix might be that it is too eager to flush, but I imagine Detailed logging is pretty exclusively used in development, where immediate flushing is desirable. As far as I can see, anything else would require a configuration parameter to control flushing options.