WAI middleware that converts a ResponseFile into ResponseStream. #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,33 @@ | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
|
|
|||
| module Network.Wai.Middleware.StreamFile where | |||
There was a problem hiding this comment.
I think this should have an explicit output list.
|
Just commenting to make sure you see that I made the requested changes. |
snoyberg
added a commit
that referenced
this pull request
Jan 5, 2015
WAI middleware that converts a ResponseFile into ResponseStream.
|
Thanks, I don't get notifications for updating commits, so a message is very useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and a simple test case.
I had a hard time figuring out a good test case, since the whole point is to make file responses look like file responses despite being a stream internally. I did add a couple to make sure it's not completely broken at least.
In response to issue #315 .