wai-app-static: honor ssIndices when used with defaultWebAppSettings

[soenkehahn]

See #376.

[soenkehahn]

I'm not sure if I prefer the version with or without the last commit (0c67261). @snoyberg: Any preference? Apart from that this is ready to merge from my side.

Any other feedback? Should I squash the commits?

[snoyberg]

I'm confused, this looks like a completely separate goal than #376. Can you clarify?

[soenkehahn]

Sorry, I was also a bit confused.

If ssLookupFile returned an LRNotFound then wai-app-static assumed that the looked up file is not a directory and it didn't bother to further check for index files. ssIndices was only ever considered when ssLookupFile returned an LRFolder. The StaticSettings created with mkSettings would not return an LRFolder, which is the cause for #376.

Personally I ran into a similar issue, not with mkSettings but with defaultWebAppSettings. Its ssLookupFile also doesn't return LRFolders for performance reasons.

With my PR in the case that ssLookupFile returns LRFolder or LRNotFound ssLookupFile will be called again, this time searching for index files. So LRFolder will not be used for looking up index files anymore. This fixes both my issue and #376. I added a test case for #376.

[soenkehahn]

The builds on travis are failing but it doesn't look like this is caused by my commits. Is travis for wai currently broken?

[snoyberg]

wai master is not broken. Can you try rebasing?

[soenkehahn]

I rebased and added f088f32, now travis is happy. I hope it's the right way to fix this. (IIUC cabal-meta doesn't pick up test dependencies.)

[soenkehahn]

Thanks for merging!