Add {test,}withApplicationSettings #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| withApplication mkApp action = do | ||
| withApplication = withApplicationSettings defaultSettings | ||
|
|
||
| -- | 'withApplication' with given 'Settings' |
There was a problem hiding this comment.
It's worth including a note that any port provided in the Settings value would be ignored.
Also, can you add a @since comment for version 3.2.7 to this and the function added below, and update the ChangeLog.md file?
|
@snoyberg I updated the PR, can you check again if everything is okay? |
| @@ -61,7 +77,7 @@ testWithApplication mkApp action = do | |||
|
|
|||
| data Waiter a | |||
| = Waiter { | |||
| notify :: a -> IO (), | |||
| notify :: a -> IO (), | |||
There was a problem hiding this comment.
I think this part of the diff was accidentally added.
There was a problem hiding this comment.
That was stylish-haskell-mode, fixed now. Thanks.
|
LGTM, just waiting on Travis before merging. |
|
Thanks for the quick turnaround on updating the PR. |
|
Thanks! |
snoyberg
added a commit
that referenced
this pull request
Apr 13, 2016
|
Warp 3.2.7 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withApplicationwas usingdefaultSettingsimplicitly, this patch implementswithApplicationSettingsandtestWithApplicationSettingsfunctions that runApplication's with givenSettings.Without this patch, I was unable to increase Warp's timeout on
testWithApplication.