New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {test,}withApplicationSettings #531

Merged
merged 1 commit into from Apr 13, 2016

Conversation

Projects
None yet
3 participants
@utdemir
Contributor

utdemir commented Apr 12, 2016

withApplication was using defaultSettings implicitly, this patch implements withApplicationSettings and testWithApplicationSettings functions that run Application's with given Settings.

Without this patch, I was unable to increase Warp's timeout on testWithApplication.

withApplication mkApp action = do
withApplication = withApplicationSettings defaultSettings
-- | 'withApplication' with given 'Settings'

This comment has been minimized.

@snoyberg

snoyberg Apr 12, 2016

Member

It's worth including a note that any port provided in the Settings value would be ignored.

Also, can you add a @since comment for version 3.2.7 to this and the function added below, and update the ChangeLog.md file?

@utdemir

This comment has been minimized.

Contributor

utdemir commented Apr 12, 2016

@snoyberg I updated the PR, can you check again if everything is okay?

@@ -61,7 +77,7 @@ testWithApplication mkApp action = do
data Waiter a
= Waiter {
notify :: a -> IO (),
notify :: a -> IO (),

This comment has been minimized.

@snoyberg

snoyberg Apr 12, 2016

Member

I think this part of the diff was accidentally added.

This comment has been minimized.

@utdemir

utdemir Apr 12, 2016

Contributor

That was stylish-haskell-mode, fixed now. Thanks.

@snoyberg

This comment has been minimized.

Member

snoyberg commented Apr 12, 2016

LGTM, just waiting on Travis before merging.

@snoyberg

This comment has been minimized.

Member

snoyberg commented Apr 12, 2016

Thanks for the quick turnaround on updating the PR.

@snoyberg snoyberg merged commit 9d4cb5f into yesodweb:master Apr 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@snoyberg

This comment has been minimized.

Member

snoyberg commented Apr 13, 2016

Thanks!

snoyberg added a commit that referenced this pull request Apr 13, 2016

@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented Jul 4, 2016

Warp 3.2.7 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment