Make ssIndices work with ssLookupFile and trailing slashes #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ embSpec = do | |||
| { requestHeaders = [("If-None-Match", "Etag 1")] } | |||
| assertStatus 304 req | |||
|
|
|||
| it "ssIndices works" $ do | |||
| it "ssIndices work" $ do | |||
There was a problem hiding this comment.
Why did you change this? I think the former grammar makes more sense (ssIndices is a singular noun as its own configuration value)
There was a problem hiding this comment.
I thought it sounded better. But here's the reverting PR: #574
|
Minor grammar comment, but not worth holding up the PR on it. Thanks! |
|
Thanks for merging! |
snoyberg
added a commit
that referenced
this pull request
Aug 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.