Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore late RST, WINDOW_UPDATE. #711

Closed

Conversation

Projects
None yet
2 participants
@lucasdicioccio
Copy link
Contributor

commented Aug 25, 2018

This commit addresses #639 by ignoring RST and WINDOW_UPDATE
frames on a closed (or-implictly-closed) stream.

TODO list:

  • Bumped the version number
  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)
Ignore late RST, WINDOW_UPDATE.
This commit addresses #639 by ignoring RST and WINDOW_UPDATE
frames on a closed (or-implictly-closed) stream.

@kazu-yamamoto kazu-yamamoto self-requested a review Aug 28, 2018

@kazu-yamamoto kazu-yamamoto added the http2 label Aug 28, 2018

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Aug 30, 2018

@kazu-yamamoto
Copy link
Contributor

left a comment

LGTM.
This passes all test case in h2spec.

@kazu-yamamoto

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2018

Rebased and merged. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.