Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore late RST, WINDOW_UPDATE. #711

Closed
wants to merge 1 commit into from
Closed

Ignore late RST, WINDOW_UPDATE. #711

wants to merge 1 commit into from

Conversation

lucasdicioccio
Copy link
Contributor

This commit addresses #639 by ignoring RST and WINDOW_UPDATE
frames on a closed (or-implictly-closed) stream.

TODO list:

  • Bumped the version number
  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@lucasdicioccio
Ignore late RST, WINDOW_UPDATE.
1c92b08 
This commit addresses yesodweb#639 by ignoring RST and WINDOW_UPDATE
frames on a closed (or-implictly-closed) stream.
@kazu-yamamoto kazu-yamamoto self-requested a review August 28, 2018 07:41
@kazu-yamamoto kazu-yamamoto mentioned this pull request Aug 29, 2018
Closed
kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Aug 30, 2018
@kazu-yamamoto
Merge PR yesodweb#711.
279ede5
kazu-yamamoto
kazu-yamamoto approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This passes all test case in h2spec.

@kazu-yamamoto
Copy link
Contributor

Rebased and merged. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
http2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasdicioccio @kazu-yamamoto