Added missing bang, which seems to resolve the memory leak in #728 #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
reviewed
Feb 19, 2019
auto-update/Control/Reaper.hs
Outdated
| @@ -156,7 +156,7 @@ add settings@ReaperSettings{..} stateRef tidRef item = | |||
| where | |||
| cons NoReaper = let !wl = reaperCons item reaperEmpty | |||
| in (Workload wl, spawn settings stateRef tidRef) | |||
| cons (Workload wl) = let wl' = reaperCons item wl | |||
| cons (Workload wl) = let !wl' = reaperCons item wl | |||
There was a problem hiding this comment.
This is a good catch, thanks, and I'm a bit embarrassed for missing it. Question: to hopefully solve this in a more guaranteed way for the future, could you tell me if making the field of the Workload constructor a strict field also solves your problem?
There was a problem hiding this comment.
New commit with a strict data constructor instead of the bangs.
…ke the data type strict.
|
This is not directly related to this issue but we should consider to add the following to |
|
@kazu-yamamoto Funnily enough, I was discussing this bug with @bitemyapp and he also mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #728.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR: