Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable maximum header size for Warp #781

Merged
merged 2 commits into from Jan 21, 2020
Merged

Configurable maximum header size for Warp #781

merged 2 commits into from Jan 21, 2020

Conversation

vapourismo
Copy link
Contributor

@vapourismo vapourismo commented Dec 7, 2019 •
edited

The rationale behind this is allowing Warp to support clients that aren't well-behaved in the sense that they send massive request paths (for example).

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@vapourismo
Copy link
Contributor Author

I am not sure if the CI failures are related to my changes.

snoyberg
snoyberg approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kazu-yamamoto any objections?

@snoyberg
Copy link
Member

@vapourismo can you rebase this against master?

@vapourismo
Copy link
Contributor Author

@vapourismo can you rebase this against master?

Will do.

@vapourismo
Copy link
Contributor Author

Actually, it looks like this is already up-to-date and on top of master.

@snoyberg
Copy link
Member

Oh, sorry about that, I misread something. I'm rerunning the failing jobs now.

@kazu-yamamoto kazu-yamamoto self-requested a review January 21, 2020 00:28
kazu-yamamoto
kazu-yamamoto approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM.

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Jan 21, 2020
@kazu-yamamoto
Merge PR yesodweb#781.
0890255
@kazu-yamamoto kazu-yamamoto merged commit 7553bd4 into yesodweb:master Jan 21, 2020
@kazu-yamamoto
Copy link
Contributor

Merged. Thank you for your contribution!

@kazu-yamamoto
Copy link
Contributor

A new version has been released.

@vapourismo vapourismo deleted the configure-header-size-limit branch April 17, 2020 22:55
@kazu-yamamoto kazu-yamamoto mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vapourismo @snoyberg @kazu-yamamoto