Getting client certificate

[kazu-yamamoto]

This should fix #482.

See also:

• Save client certificate into Context haskell-tls/hs-tls#405
• exposing getClientCertificateChain. haskell-tls/hs-tls#407

[snoyberg]

What's the motivation for using a bottom value here instead of propagating the Maybe? If we need to distinguish different cases, I'd rather a specific sum type to represent the different ways things can fail.

[kazu-yamamoto]

Oh. It's from copy-and-paste. Does the following code make sense?

clientCertificate :: Request -> Maybe CertificateChain
clientCertificate = join . Vault.lookup getClientCertificateKey . vault

[snoyberg]

Yup, seems reasonable.

[kazu-yamamoto]

Thanks. I pushed this. Can we merge this PR now?

[snoyberg]

I think the version bump has broken all of CI. Do you want me to take a crack at fixing that before we merge?

[kazu-yamamoto]

No rush. Now I think we should wait for getting tls 1.5.3 released.

[kazu-yamamoto]

New versions of tls and tls-session-manager have been released.
@snoyberg Would you try to fix CI?

[snoyberg]

@kazu-yamamoto did the package that provides the Data.X509 module change? I'm seeing this:

warp               > /home/vsts/work/1/s/warp/Network/Wai/Handler/Warp/Types.hs:11:1: error:
warp               >     Could not load module ‘Data.X509’
warp               >     It is a member of the hidden package ‘x509-1.7.5’.
warp               >     Perhaps you need to add ‘x509’ to the build-depends in your .cabal file.
warp               >     Use -v to see a list of the files searched for.
warp               >    |

I've pushed my attempted CI fixes to this branch.

[kazu-yamamoto]

I compared v1.5.2 and v1.5.3 but there is no change for exporting. Very strange.

@ocheron Any thoughts?

[kazu-yamamoto]

@snoyberg f828294 added x509 as dependency. That's why?

[ocheron]

Apparently it's needed in the benchmark module too but wasn't added.

[kazu-yamamoto]

@ocheron Wow! Nice catch! Thanks. Hoping that CI will recover.

[kazu-yamamoto]

@snoyberg Should we also add tls-session-manager-0.0.4 to extra-deps:?

[snoyberg]

Yes, good call. I've pushed a bunch of updates on the branch, including updates to the stack.yaml files and a lower bound in warp-tls. I've also improved the build matrix a bit by dropping 8.0.2 (no longer supported) and adding in 8.8.1 testing.

[snoyberg]

@kazu-yamamoto woohoo, looks like CI passed!

[kazu-yamamoto]

@snoyberg Thanks! I have merged this PR.

[kazu-yamamoto]

I have released new versions of warp and warp-tls.