Convert ResourceVanished error to ConnectionClosedByPeer exception an… #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
approved these changes
Mar 1, 2020
There was a problem hiding this comment.
Seems reasonable to me. @kazu-yamamoto can you give this a check as well?
marinelli
force-pushed
the
warp-catch-resource-vanished
branch
from
544561e
to
1b3a92a
Compare
|
Hi @kazu-yamamoto, |
|
Sorry for the delay. I didn't notice this. I have merged this PR. |
|
It would be helpful to have a new release. |
|
@snoyberg This changed the behavior. Would you suggest a new version number? |
|
I don't think it's necessary
…On Wed, Apr 8, 2020, 3:29 AM Kazu Yamamoto ***@***.***> wrote:
@snoyberg <https://github.com/snoyberg> This changed the behavior. Would
you suggest a new version number?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#795 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMCBY3BEFIYFOMXJHY5NLRLPANZANCNFSM4K467U6Q>
.
|
|
@snoyberg Did you mean that 3.3.10 is good enough? |
|
Yes I think it's fine |
|
@snoyberg Thank you! |
|
3.3.10 has been released. |
|
Thank you everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d refine the catching
Hi everyone. At @typeable, we have a big web application, one of its components is a web API served by a warp+wai+servant server. Every request takes a lot of time to be resolved due to connections to multiple external interfaces. If I close the http client (for example killing curl or closing the browser),
warpreturns an error likeNetwork.Socket.sendBuf: resource vanished (Broken pipe).The reason is that the function
socketConnection, in theNetwork.Wai.Handler.Warp.Runmodule, calls thesendAllfunction (from theNetwork.Socket.ByteStringmodule) but the remote http client has already closed the connection.I tried to create a simple example to reproduce this error, without success.
It might be related to #196 or some bad interactions between warp+wai and the servant application. I have to admit that I still don't know the reason.
Anyway, inspired by this old issue #421, I think it would be good to catch the
IOExceptionwith error typeResourceVanishedand throw aConnectionClosedByPeer, like has been done in theNetwork.Wai.Handler.WarpTLSmodule.I also refined the exception catching for both the
warpandwarp-tlspackage like was suggested here 91d0546#r12752366.What do you think?