Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warp-tls: setSocketCloseOnExec #923

Closed
wants to merge 1 commit into from
Closed

warp-tls: setSocketCloseOnExec #923

wants to merge 1 commit into from

Conversation

TristanCacqueray
Copy link
Contributor

Fixes: #922

  • Bumped the version number
  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@TristanCacqueray
Copy link
Contributor Author

That seems to work, please let me know if that looks good to you and I'll update the changelog.

kazu-yamamoto
kazu-yamamoto approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Mar 16, 2023
@kazu-yamamoto
Merge PR yesodweb#923
d692ea9
@kazu-yamamoto
Copy link
Contributor

Rebased and merged. Thank you for your contribution!

@kazu-yamamoto
Copy link
Contributor

A new version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warp-tls is not setting FD_CLOEXEC on the listening socket
2 participants
@TristanCacqueray @kazu-yamamoto