Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wai: add getRequestBodyChunk to silence requestBody deprecation warning #949

Closed
wants to merge 1 commit into from

Conversation

dbeacham
Copy link

@dbeacham dbeacham commented Oct 16, 2023

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@Vlix
Copy link
Contributor

Vlix commented Oct 17, 2023

Thank you for the PR!

I think the name setRequestBodyChunk makes sense to be the opposite of getRequestBodyChunk, but you're not setting a chunk when using this setter, so I think just keeping it as setRequestBody might be better. Or maybe even replaceRequestBody 🤔

@dbeacham
Copy link
Author

Yeah - name could be better. setRequestBodyChunks is another alternative.

@Vlix
Copy link
Contributor

Vlix commented Oct 17, 2023

@dbeacham could you add to the conversation in #849 ?

@kazu-yamamoto
Copy link
Contributor

@Vlix This PR looks good to me. May I merge this as is?

@Vlix
Copy link
Contributor

Vlix commented Oct 18, 2023

There should be an @since declaration, version bump and addition to the ChangeLog, no?

@dbeacham
Copy link
Author

Yeah. I'll sort that out later today.

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Oct 19, 2023
@kazu-yamamoto
Copy link
Contributor

Rebased and merged.
Thank you all for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants