Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add and use RequestParseException in Network.Wai.Parse #964

Closed
wants to merge 6 commits into from

Conversation

ocramz
Copy link

@ocramz ocramz commented Dec 25, 2023

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

closes #963

@ocramz
Copy link
Author

ocramz commented Dec 28, 2023

Hi @snoyberg @kazu-yamamoto could you trigger CI so we can see if this can be merged? Thanks!

@ocramz ocramz mentioned this pull request Dec 29, 2023
5 tasks
@snoyberg
Copy link
Member

Done

@ocramz
Copy link
Author

ocramz commented Dec 29, 2023

@snoyberg It appears that the failing CI checks are due to building against Stackage Nightly specifically :

https://github.com/yesodweb/wai/actions/runs/7321420371/job/20020277065?pr=964#step:3:570

What's a good course of action in this case?

@snoyberg
Copy link
Member

I’ll defer to @kazu-yamamoto i haven’t been maintaining things recently

@kazu-yamamoto
Copy link
Contributor

@ocramz Would you rebase this onto the current master and do push -f to see a new CI result?
#966 has fixed something about stack.

@kazu-yamamoto kazu-yamamoto mentioned this pull request Jan 10, 2024
@kazu-yamamoto
Copy link
Contributor

Merged via #964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wai-extra: Safe handling of temp files that exceed configured limits
3 participants