Eagerly remove Handles from the manager
#986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinleyMcIlwaine
force-pushed
the
finley/eager-handle-deletion
branch
4 times, most recently
from
b46f16a
to
8812303
Compare
It is convenient to be able to modify reaper workloads outside of the `reaperAction` in scenarios where we don't want to wait for `reaperDelay` for the jobs to be updated. This PR adds an atomic `reaperModify` function to the reaper API which enables this. Since this changes the visible `Reaper` constructor, I did a major version bump (`auto-update` 0.1.6 -> 0.2.0) and added a changelog entry. I also bumped the `warp` dependency on `auto-update`.
`cancel` used to mark the given `Handle` as `Canceled`, which relied on the reaper to run and clean up the `Canceled` handles. This is not good for long timeouts when many streams are opened, as a lot of `Canceled` handles build up in the reaper's workload. This commit uses the reaper's new `reaperModify` API to immediately remove the given `Handle` in `cancel`. This obsoletes the `Canceled` constructor of `State`, so we remove that as well. We update the time-manager dependency of warp to include the new changes as well. The related auto-update changes are in PR yesodweb#985.
FinleyMcIlwaine
force-pushed
the
finley/eager-handle-deletion
branch
from
8812303
to
e6f2120
Compare
kazu-yamamoto
added a commit
to kazu-yamamoto/wai
that referenced
this pull request
Apr 27, 2024
|
Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #985. That should be merged first, then this can be rebased on
mainand merged.Previously, if many streams were opened on a connection with a very long timeout, the handles would accumulate. This PR causes the handles to be removed from the manager immediately upon
cancel, instead of relying on timeouts causing the reaper to remove them.Before submitting your PR, check that you've:
After submitting your PR: