Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yesod cache does not store nested cached action results #1266

Closed
CthulhuDen opened this issue Aug 26, 2016 · 1 comment
Closed

Yesod cache does not store nested cached action results #1266

CthulhuDen opened this issue Aug 26, 2016 · 1 comment

Comments

@CthulhuDen
Copy link
Contributor

CthulhuDen commented Aug 26, 2016 •
edited
Loading

I am talking about per-request cache (Yesod.Core.Handler.cached).

When [cached'](https://github.com/yesodweb/yesod/blob/master/yesod-core/Yesod/Core/Handler.hs#L997) executes action which also calls cached, outer cachedwill override new cache entries having been created during innercached` invocations. I suggest merging cached types map instead of overwriting it here.
@CthulhuDen CthulhuDen changed the title Yesod cache does not store nested cached action result. Yesod cache does not store nested cached action results Aug 26, 2016
@snoyberg
Copy link
Member

SGTM. Want to send a PR?

@CthulhuDen CthulhuDen mentioned this issue Aug 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoyberg @CthulhuDen